Update connection.go: Added Tesla HomeAssistant chargingstates #24682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added charging states of Tesla Model Y juniper in HomeAssistant to the chargeStatusMap. Below the possible states in HomeAssistant of the sensor. options: - starting - charging - stopped - complete - disconnected - no_power device_class: enum friendly_name: Tesla Model Y Opladen
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Add a mapping for the 'disconnected' state (e.g., map 'disconnected' to api.StatusA) so none of the sensor options are missing.
- Verify whether 'complete' should be mapped to StatusC instead of StatusB to accurately reflect a fully charged state.
- Align the indentation for the new entries (complete and stopped) with the surrounding mappings for consistency.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Add a mapping for the 'disconnected' state (e.g., map 'disconnected' to api.StatusA) so none of the sensor options are missing.
- Verify whether 'complete' should be mapped to StatusC instead of StatusB to accurately reflect a fully charged state.
- Align the indentation for the new entries (complete and stopped) with the surrounding mappings for consistency.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
andig
reviewed
Oct 24, 2025
| "true": api.StatusC, | ||
| "active": api.StatusC, | ||
| "1": api.StatusC, | ||
| "starting": api.StatusC, |
|
Imho, rather than adding more (and partially arbitrary) states, we should allow customizing this in the template: disconnected:
- foo
- ...
connected:
- ...
charging:
- ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added charging states of Tesla Model Y juniper in HomeAssistant to the chargeStatusMap. Below the possible states in HomeAssistant of the sensor.
options:
friendly_name: Tesla Model Y Opladen