Goodwe-Hybrid: Add maxchargepower, maxdischargepower , minsoc and maxsoc

[mfuchs1984]

Fix #24991

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `templates/definition/meter/goodwe-hybrid.yaml:233-235` </location>
<code_context>
                 type: writemultiple
                 encoding: uint16
   capacity: {{ .capacity }} # kWh
+  maxchargepower: {{ .maxchargepower }} # W
+  minsoc: {{ .minsoc }} # %
+  maxsoc: {{ .maxsoc }} # %
   {{- end }}
</code_context>

<issue_to_address>
**suggestion:** Consider including 'maxdischargepower' in the rendered output for completeness.

Since 'maxchargepower' is present, adding 'maxdischargepower' would improve consistency and ensure all relevant parameters are available for downstream use.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[mfuchs1984]

Could you help me understand what's wrong with the UI job?

[andig]

Looks like invalid white space or line feed?

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[mfuchs1984]

I know there were some discussions on the defaults. Should we keep them or not? What happens when they are not configured, will evcc enforce setting them?

[andig]

Should we keep them or not?

Or not. That's why we have them ;)

will evcc enforce setting them?

As test will show- yes.

[mfuchs1984]

@naltatis Looks like the settings don't show up in the UI configuration. When looking at e.g. Tesla Powerwall, they show up in the advanced settings section. In the Powerwall template, they are marked with advanced: true. Shouldn't they also show up when they are not advanced, something missing in the UI? Or should they always be advanced?