invocations method is clarified#1
Open
aaronjensen wants to merge 1 commit intoeventide-project:masterfrom
Open
invocations method is clarified#1aaronjensen wants to merge 1 commit intoeventide-project:masterfrom
aaronjensen wants to merge 1 commit intoeventide-project:masterfrom
Conversation
aaronjensen
force-pushed
the
invocation-method
branch
from
4400a57 to
750f41b
Compare
aaronjensen
commented
Jul 24, 2024
|
|
||
| invocations = __records.select { |invocation| invocation.method_name == method_name } | ||
|
|
||
| if parameters.nil? |
Collaborator
Author
There was a problem hiding this comment.
@sbellware This is actually wrong -- parameters will always be a hash, and never nil. I replicated defect in my change. It's innocuous ultimately, but it's misleading.
Collaborator
Author
There was a problem hiding this comment.
I updated mine to use parameters.empty?
aaronjensen
force-pushed
the
invocation-method
branch
from
750f41b to
f4e343b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.