Add boolean match played status; Differentiate between upcoming and p…#1267
Open
labodm wants to merge 1 commit intoevroon:masterfrom
Open
Add boolean match played status; Differentiate between upcoming and p…#1267labodm wants to merge 1 commit intoevroon:masterfrom
labodm wants to merge 1 commit intoevroon:masterfrom
Conversation
…ast matches in dashboard and results page
|
@maiklabod is attempting to deploy a commit to the evroon's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
Thanks for this! I haven't looked at it because of vacation so it will take 2 weeks or so before i have the chance to review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new match attribute called "played" which is a boolean flag, whether a match has been played or not. This helps in differentiating between upcoming and past matches, especially when entering results or viewing the dashboard.
Therefore, I added two different tabs to the dashboard, as well as the results page, to view the upcoming and past matches. This makes entering results way easier and stops heavy scrolling/searching in big round robin stages.
I also changed the layout of the new past results in the dashboard. If we want to keep this consistent, I could add a setting that switches between the compact and the extended stage item view. Just let me know.