Fix: Replace deprecated double(11,2) with decimal(10,2) in ext_tables.sql #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….sql The ext_tables.sql file used the deprecated MySQL syntax `double(11,2)` for decimal fields, which causes constant schema migration prompts when running DB compare. MySQL/MariaDB interprets `double(11,2)` ambiguously, and Doctrine DBAL schema comparison detected a type mismatch between the defined schema and what TYPO3 generates from TCA configuration. The TCA defines these fields as `type => 'number'` with `format => 'decimal'`, which TYPO3's DefaultTcaSchema class converts to decimal(10,2). This change replaces all occurrences of `double(11,2)` with `decimal(10,2)` to align with TYPO3's schema generation and eliminate the persistent migration warnings. Affected fields: - tx_cart_domain_model_order_item: gross, net, total_gross, total_net - tx_cart_domain_model_order_taxclass: calc - tx_cart_domain_model_order_tax: tax - tx_cart_domain_model_order_product: price, discount, gross, net, tax - tx_cart_domain_model_order_discount: gross, net, tax - tx_cart_domain_model_order_shipping: gross, net, tax - tx_cart_domain_model_order_payment: gross, net, tax - tx_cart_domain_model_coupon: discount, cart_min_price
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ext_tables.sql file used the deprecated MySQL syntax
double(11,2)for decimal fields, which causes constant schema migration prompts when running DB compare.MySQL/MariaDB interprets
double(11,2)ambiguously, and Doctrine DBAL schema comparison detected a type mismatch between the defined schema and what TYPO3 generates from TCA configuration. The TCA defines these fields astype => 'number'withformat => 'decimal', which TYPO3's DefaultTcaSchema class converts to decimal(10,2).This change replaces all occurrences of
double(11,2)withdecimal(10,2)to align with TYPO3's schema generation and eliminate the persistent migration warnings.Affected fields:
Resolves: #711