-
Notifications
You must be signed in to change notification settings - Fork 1
[#33] platform 서비스 -> payments 서비스 grpc 통신 #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
토스 : 결제유형별(카드,간편,가상계좌) 요청/응답 호출 동일, 파라미터 구조는 동일하지만 결제유형에 따라 nullable nhn : 카드,간편결제 요청/응답 호출 동일하다. (구현중)
토스 : 결제유형별(카드,간편,가상계좌) 요청/응답 호출 동일, 파라미터 구조는 동일하지만 결제유형에 따라 nullable nhn : 카드,간편결제 요청/응답 호출 동일하다. (구현중)
# Conflicts: # platform/src/main/java/com/commerce/platform/core/application/in/PaymentUseCaseImpl.java # platform/src/main/java/com/commerce/platform/core/application/out/PgStrategy.java # platform/src/main/java/com/commerce/platform/infrastructure/adaptor/PgCacheService.java # platform/src/main/java/com/commerce/platform/infrastructure/pg/DanalStrategy.java # platform/src/main/java/com/commerce/platform/infrastructure/pg/nhn/NHNStrategy.java # platform/src/main/java/com/commerce/platform/infrastructure/pg/toss/TossStrategy.java # platform/src/test/java/com/commerce/platform/core/application/in/PaymentUseCaseImplTest.java # platform/src/test/java/com/commerce/platform/core/domain/service/PaymentPgRouterTest.java
TossPgStrategy .. : PgStrategy 메소드 구현 및 해당 pg사의 특성에 맞게 내부적으로 결제유형별 추상화
기존 주문검증 및 결제처리하는 로직은 paymentService 에서 처리한다.
f-lab-lyan
approved these changes
Jan 3, 2026
Collaborator
f-lab-lyan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.