fix(pkg/jsonutils): add description to resource list, unskip test #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating a separate issue (PR incoming), I noticed that the
TestResourcesCmdRun_Successhad been recently skipped. This led me down a small rabbit hole of fixing up the output of that command.Here's what I changed:
pkg/jsonutils:descriptionfield to the output of theresourcescommand, which was the original reason for the test being skipped.formatResourcesListto correctly align with and without coloured output (pet peeve). The main thing to note here is thattext/tabwriter's elastic tabstop algorithm still considers colour escape sequences as part of the 'cells', so it's important to take the length of those sequences into account. I ended up also colouring the second line of the output,but can keep it uncoloured if you prefer(EDIT: this might not be as straightforward as I originally thought).typefield of theresourcescommand to the correctmimeType.cmd/mcptools/commands:TestResourcesCmdRun_Success.The below sample output is from an MCP server I am currently working on.
Before:
After: