Component | Stacked Bar: Add stacked spacing option #611
Conversation
lee00678
left a comment
lee00678
left a comment
There was a problem hiding this comment.
@dennisadriaans great addition.
I see one small issue (below)
| // Only apply spacing between inner segments (not at base or top) | ||
| const isInnerStack = accessorIndex > 0 && accessorIndex < this.getAccessors().length | ||
| if (!isEntering && stackSpacing > 0 && isInnerStack) { | ||
| if (this.isVertical()) { |
There was a problem hiding this comment.
When there are both negative and positive value in the same group,
dennisadriaans
force-pushed
the
feature/stacked-bar-padding
branch
from
7f81b39 to
88e0d43
Compare
|
Spacing, radius and crosshair should be good for both positive and negative values now. The crosshair for horizontal orientation seems bugged, but it looks like this happens in the main branch too |
Yea, we don't currently support horizontal crosshair. |
|
@dennisadriaans this looks good! It should be nice to have some documentation for this on the website. Do you have bandwidth? If not, I can add it. |
|
Added doc. |
lee00678
left a comment
lee00678
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
|
@suryahanumandla Great observation about the spacing, thanks for double checking! Also the space at the bottom looks off. 
I think the screenshot you've shared looks good. What is your concern? |
|
The inconsistent spacing happens when the stackedSpacing is increased. Currently, we subtract the spacing visually from a stacked item to keep it aligned with the value on the y-axis. I'm not sure how to correct this. Any suggestions? |
|
@dennisadriaans I'll take a look at it, thanks. |
|
I'm converting this to draft until it's ready. cc @dennisadriaans |
4 participants
This adds an option to apply spacing between stacked items within a single bar. Applies radius application across all stacked items when a chart-wide radius is set.