Conversation
Summary of ChangesHello @csegarragonz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the badges in the README.md file, notably switching to a dynamic version badge from shields.io. While this is a good improvement, I've provided a suggestion to restore the clickability of the version badge by linking it to the project's releases page, and to improve the overall HTML formatting for better readability and maintainability.
| <p style="display: flex; gap: 6px; justify-content: center; align-items: center;"> | ||
| <img | ||
| src="https://img.shields.io/github/v/tag/faasm/tless?sort=semver&label=version" | ||
| alt="Accless Version" | ||
| /> | ||
| <a href="https://github.com/faasm/tless/actions/workflows/tests.yml"><img src="https://github.com/faasm/tless/actions/workflows/tests.yml/badge.svg" alt="Integration Tests" /></a> | ||
| <a href="https://github.com/faasm/tless/actions/workflows/snp.yml"><img src="https://github.com/faasm/tless/actions/workflows/snp.yml/badge.svg" alt="SNP End-to-End Tests" /></a> | ||
| </p> |
There was a problem hiding this comment.
The new dynamic version badge is a great change! However, the updated HTML block has a couple of issues: the version badge is no longer clickable, and the formatting for the other badges has become less readable. I'd suggest wrapping the version badge in a link to the releases page and restoring the multi-line formatting for all badges to improve readability and maintainability.
| <p style="display: flex; gap: 6px; justify-content: center; align-items: center;"> | |
| <img | |
| src="https://img.shields.io/github/v/tag/faasm/tless?sort=semver&label=version" | |
| alt="Accless Version" | |
| /> | |
| <a href="https://github.com/faasm/tless/actions/workflows/tests.yml"><img src="https://github.com/faasm/tless/actions/workflows/tests.yml/badge.svg" alt="Integration Tests" /></a> | |
| <a href="https://github.com/faasm/tless/actions/workflows/snp.yml"><img src="https://github.com/faasm/tless/actions/workflows/snp.yml/badge.svg" alt="SNP End-to-End Tests" /></a> | |
| </p> | |
| <p style="display: flex; gap: 6px; justify-content: center; align-items: center;"> | |
| <a href="https://github.com/faasm/tless/releases"> | |
| <img | |
| src="https://img.shields.io/github/v/tag/faasm/tless?sort=semver&label=version" | |
| alt="Accless Version" | |
| /> | |
| </a> | |
| <a href="https://github.com/faasm/tless/actions/workflows/tests.yml"> | |
| <img | |
| src="https://github.com/faasm/tless/actions/workflows/tests.yml/badge.svg" | |
| alt="Integration Tests" | |
| /> | |
| </a> | |
| <a href="https://github.com/faasm/tless/actions/workflows/snp.yml"> | |
| <img | |
| src="https://github.com/faasm/tless/actions/workflows/snp.yml/badge.svg" | |
| alt="SNP End-to-End Tests" | |
| /> | |
| </a> | |
| </p> |
No description provided.