lib: chain: remove empty sets and rules referencing them #400
+281
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for empty sets based on #386. (Note: As of now, this is slightly different than the behavior defined in #386 - instead of removing just the matcher, the entire rule is removed to keep the semantics of the ruleset the same. I added more details in the comment there, but of course happy to switch this to the original plan.)
Previously, having any matcher with an empty set caused an error and the entire ruleset was rejected. Now, we treat the matcher with an empty set as a no-op (always false) and remove any rule that contains a matcher with an empty set (as the rule would always evaluate to false). We alert the user to this by sending a warning for each rule that will be ignored.
Test Plan:
bf_chain_new