Closed
Conversation
jaymzh
force-pushed
the
fix-hardcode-paths
branch
from
278518a to
7f09d5e
Compare
This adds a configuration for `chef_config_dir` where we can look for the prod cert link rather than assuming `/etc/chef` - so that those using cinc can use chefctl more easily. The default is, of course `/etc/chef` so nothing will change for anyone not specifying this config. Also: gem file update is to fix tests - rubocopy fails to run without base64 installed: ``` /opt/hostedtoolcache/Ruby/3.4.1/x64/lib/ruby/3.4.0/bundled_gems.rb:82:in 'Kernel.require': cannot load such file -- base64 (LoadError) ``` Side note, what I really wanted to do was create a `client_distro`, and then build the defaults based on _that_, but to allow people to still be able to overwrite _that_ requires significant refactoring, using the new `default(..)` syntax for mixlib-config and then creating a method for most of the configs, and that seemed like too much change for something so small, so I did not. Signed-off-by: Phil Dibowitz <[email protected]>
jaymzh
force-pushed
the
fix-hardcode-paths
branch
from
989fabb to
4f6b38c
Compare
Contributor
|
@dafyddcrosby has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
This pull request has been merged in 0a79708. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a configuration for
chef_config_dirwhere we can look forthe prod cert link rather than assuming
/etc/chef- so that thoseusing cinc can use chefctl more easily.
The default is, of course
/etc/chefso nothing will change for anyonenot specifying this config.
Also: gem file update is to fix tests - rubocopy fails to run without
base64 installed:
Side note, what I really wanted to do was create a
client_distro, andthen build the defaults based on that, but to allow people to still be
able to overwrite that requires significant refactoring, using the new
default(..)syntax for mixlib-config and then creating a method formost of the configs, and that seemed like too much change for something
so small, so I did not.
Signed-off-by: Phil Dibowitz [email protected]