vsdebug: Fix double-closing listener FDs #9681
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszabo-wikia
force-pushed
the
fix-vsdebug-listener-fd-close
branch
from
cca9d9b to
7ef2280
Compare
Contributor
|
@mszabo-wikia has updated the pull request. You must reimport the pull request before landing. |
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D88280004. (Because this pull request was imported automatically, there will not be any future comments.) |
While working on D88186184, I noticed that we were closing the listener FDs for the vsdebug server in both `waitForConnection` and `listenForClientConnection`. It does not seem to be causing issues in local testing but it could be a problem if the FD gets reused in a different thread in the meantime. `waitForConnection` is only called at the end of `listenForClientConnection` so closing the FDs only at the end of `listenForClientConnection` should be fine.
mszabo-wikia
force-pushed
the
fix-vsdebug-listener-fd-close
branch
from
7ef2280 to
0a42245
Compare
Contributor
|
@mszabo-wikia has updated the pull request. You must reimport the pull request before landing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on D88186184, I noticed that we were closing the listener FDs for the vsdebug server in both
waitForConnectionandlistenForClientConnection. It does not seem to be causing issues in local testing but it could be a problem if the FD gets reused in a different thread in the meantime.waitForConnectionis only called at the end oflistenForClientConnectionso closing the FDs only at the end oflistenForClientConnectionshould be fine.