Fix constrained TypeVar inference in subtype checking (#2221) #2225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2221
When inferring constrained TypeVars during subtype checking (
Var(TypeVar) <: ConcreteType), pyrefly was incorrectlysetting the TypeVar to the concrete type and then checking if it satisfies the constraint. This fails for constrained
TypeVars which must be inferred to exactly one of their constraint types per PEP 484.
The Bug
This valid code produced:
ERROR
Bufferis not assignable to upper boundbytes | strof type variableAnyStrRoot Cause
shutil.copyfileobj has signature (fsrc: SupportsRead[AnyStr], fdst: SupportsWrite[AnyStr]) where AnyStr = TypeVar("AnyStr",
str, bytes).
When checking BufferedWriter <: SupportsWrite[AnyStr]:
The Fix
For constrained TypeVars, find a constraint that satisfies the subtype relationship rather than directly assigning the
concrete type. This follows PEP 484 semantics: constrained TypeVars must be inferred to exactly one of their constraint
types.
Test Plan