Skip to content

Test improvement: removed Magic Number test smell #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gvma wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Test improvement: removed Magic Number test smell #690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion stetho-okhttp/src/test/java/com/facebook/stetho/okhttp/StethoInterceptorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ public class StethoInterceptorTest {
@Rule
public PowerMockRule rule = new PowerMockRule();

private final int HTTP_OK = 200;
private NetworkEventReporter mMockEventReporter;
private StethoInterceptor mInterceptor;
private OkHttpClient mClientWithInterceptor;
Expand Down Expand Up @@ -96,7 +97,7 @@ public void testHappyPath() throws IOException {
Response reply = new Response.Builder()
.request(request)
.protocol(Protocol.HTTP_1_1)
.code(200)
.code(HTTP_OK)
.body(ResponseBody.create(MediaType.parse("text/plain"), originalBodyData))
.build();
Response filteredResponse =
Expand Down