Skip to content

Conversation

@laresbernardo
Copy link
Contributor

@laresbernardo laresbernardo commented Feb 4, 2025

  • fix: It seems there's an issue on counting the periods in some cases. When testing c("2022-06-01", "2023-05-01") for example, I get 2 periods, which is incorrect. (See below)
  • feat: adding total input and calculation results in caption when date range or metric value are provided into robyn_response().
  • feat: for further clarification, added time granularity in x axis and dep variable in y axis.

PENDING BEFORE MERGING:

  • Strange results are showing up sometimes. When metric_value = 0, I see the blue dot is larger than the grey dot, which is historical - which doesn't make sense. Maybe fixing the prior point fixes this as well. (See below)
  • When using the date_range with narrower date range and NULL ("all"), I'm getting the same grey dot data in subtitle.
  • What's the difference between sum(resp$input_total) and metric_value? @gufengzhou

…rovided in robyn_response()'s plot + labeling improvements
@laresbernardo laresbernardo self-assigned this Feb 4, 2025
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 4, 2025
@laresbernardo
Copy link
Contributor Author

Example of metric_value = 0 result.
image

Example of metric_value = NULL result.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants