-
Notifications
You must be signed in to change notification settings - Fork 60
FeedSim build scripts improvements #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2-beta
Are you sure you want to change the base?
Conversation
|
I remember fast_float is a dependency of fbthrift so we can't remove it - unless you've validated that it's not used by fbthrift when building on aarch64 |
|
@ahmadelyoussef has imported this pull request. If you are a Meta employee, you can view this in D87904059. |
Thanks. Just confirmed that fast_float is indeed required by folly (see https://github.com/facebook/fbthrift/blob/be70399cc5f6371a8b9c74a6647d280f20d2e1ae/build/fbcode_builder/manifests/folly#L23). |
|
@excelle08 @ahmadelyoussef I wanted to also apply these changes to the Ubuntu install script and realized that all the install scripts are mostly redundant so I merged them into a single install script for both architectures and both Linux distributions |
The suggested changes improve the speed and integrity of the FeedSim installation on aarch64 CentOS:
fast_floatfolderOpen questions:
fast_floatis installed but never used by FeedSim or its dependencies. Can it safely be removed?