Fix issue with delete_order #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete 'JSONDecodeError' Update rest_client.py c c c c Revert "c" This reverts commit 6913177. Revert "c" This reverts commit a61a0e9. Revert "c" This reverts commit 1d2e810. Revert "c" This reverts commit 0b88f05. Revert "Update rest_client.py" This reverts commit 7110a76. Revert "Update rest_client.py" This reverts commit 7a4510f. add handling if no return body present
Author
|
Hey @jonathanelscpt - have you had a chance to look at this? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TlDr: The _do method was not handling the body-less response resonse from VALRs API. To fix this I created a new method called do_delete which skips a lot of the error handling in _do, just returning the request object.