Open
Conversation
Node's test runner works from root No need to change directory
Broken method lacks return Silent bug lurks in the code Thanks Brian
Unused language departs
Modify plugin loading to support test environments where plugins are listed as devDependencies. Enhance plugin detection by checking both dependencies and devDependencies to ensure comprehensive plugin discovery.
Extend plugin page discovery to include plugins from devDependencieswhen no plugins are found in dependencies. This improves flexibilityfor development and testing scenarios by allowing plugin pages to beloaded from development dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to Brian for spotting that the npm scripts for running the test would never run. These changes fixes that, and resolves issues with failing tests.
N.B. Luckily those things that were not working were due to differences in location of components between running tests here and running from within the ‘wiki’ package.
Changes
isWorkingmethod in sitemap to return correctly