Skip to content

Chore: ruff rule: ANN001 - a sub-issue task of #631 #638: missing-type-function-argument #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Chore: ruff rule: ANN001 - a sub-issue task of #631 #638: missing-type-function-argument #708

wants to merge 9 commits into from

Conversation

@Topor24k
Copy link

@Topor24k Topor24k commented Oct 26, 2025 •
edited
Loading

Removed the line in pyproject.toml that disables rule "ANN001" (missing-type-function-argument) and reformatted the code. Ran just format and just lint to fix remaining violations.

#638

Issue(s)

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature
    • Core Air (Air Tags, Request/Response cycle, etc)
    • Optional (Authentication, CSRF, etc)
    • Third-Party Integrated (Cookbook documentation on using Air databases or a task manager, etc)
    • Out-of-Scope (Formal integration with databases, external task managers, or commercial services etc - won't be accepted, please create a separate project)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Pull request tasks

The following have been completed for this task:

  • Removed ANN001 from pyproject.toml
  • Code formatting applied using just format, just format-concise, or just format-grouped
  • Manual fixes applied for any remaining lint violations
  • Ran just lint, just lint-concise, or just lint-grouped to verify no violations remain
  • Documentation changes for new or changed features
  • Alterations of behavior come with a working implementation in the examples folder
  • Tests on new or altered behaviors

Checklist

  • I have run just test and just qa, ensuring my code changes passes all existing tests
  • I have performed a self-review of my own code
  • I have ensured that there are tests to cover my changes

Demo or screenshot

Other information

@codecov
Copy link

codecov bot commented Oct 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Topor24k Topor24k changed the title Sub issue Chore: ruff rule: ANN001 - a sub-issue task of #631 #638 Oct 26, 2025
@pygarap pygarap linked an issue Oct 26, 2025 that may be closed by this pull request
Chore: ruff rule: ANN001 - a sub-issue task of #631 #638
Open
@pygarap pygarap self-requested a review October 26, 2025 23:54
pygarap
pygarap requested changes Oct 27, 2025
View reviewed changes
Copy link
Collaborator

@pygarap pygarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this pull request is well prepared and the implementation looks solid.

Please review and address the comments I have provided. Once those points are resolved, I believe this will be ready to proceed.

src_examples/forms__AirForm__example.py
@@ -0,0 +1,24 @@
"""Small examples for AirForm and AirField usage.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be included in this PR!

tests/test_src_examples_forms.py
@@ -0,0 +1,43 @@
import pytest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be included in this PR!

@pydanny pydanny changed the title Chore: ruff rule: ANN001 - a sub-issue task of #631 #638 Chore: ruff rule: ANN001 - a sub-issue task of #631 #638: missing-type-function-argument Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pygarap pygarap pygarap requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Topor24k Topor24k

Labels

Status: Do Not Merge! ❌ Status: In Review 👀

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Chore: ruff rule: ANN001 - a sub-issue task of #631

2 participants

@Topor24k @pygarap