-
Notifications
You must be signed in to change notification settings - Fork 19
Better titles, changed default #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
4babbbd to
f9b464f
Compare
| legacy=True, | ||
| ), | ||
| "DelineateAnything-S": ModelSpec( | ||
| title="DelineateAnything v1: small, single window", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also assign 2 or 3 class or something similar to Delineate Anything? @isaaccorley
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can say 'instance segmentation model', as it goes straight to a vector afaict. We could potentially clarify in all the FTW ones that they go to a 2 or 3 class raster and then get vectorized in a post-processing step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be a little too technical terminology, also the difference is not obvious in the app as all go directly to vector there.
On the other hand, the 2v3 class categorization also doesn't make sense in the app due to that. At least I assume that the results of 2v3 class in the app will likely be the same or very similar.
Of course, the app is not the only interface and we probably shouldn't hardcode titles that are only useful for the app. But at least right now we are only using them in the app...
Edit: Things would change once we offer the GeoTIFF for download, which we can for batch jobs already, just needs a slight update, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also want us to display the geotiff, not just have it for download...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, two steps though :-) I can implement download today (I think), viewing probably needs a bit more work with a map mode / layer switcher etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably fine to not display 2 vs 3 class models in the app as all the new models are always 3 class and seems like the user only sees the polygon outputs anyway.
f9b464f to
969a646
Compare
| legacy=False, | ||
| ), | ||
| "FTW_PRUE_EFNET_B3": ModelSpec( | ||
| title="FTW v3 PRUE EfficientNet-B3: 3-class, full, multi window", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does PRUE stand for?
969a646 to
3608ccb
Compare
3608ccb to
048d122
Compare
More questions below