build: update checkout action to v5 #13250
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately there's some weird interaction between actions/checkout and actions/upload-artifact: https://github.com/filecoin-project/lotus/actions/runs/16900001804/job/47877218093?pr=13250; I'm not sure what's going on there. But upload-artifact is still on node20: actions/upload-artifact#719; I don't think that explains this problem, but it does speak to how out of date it is. |
|
Hi @rvagg Should I use checkout@v5 only in jobs without upload-artifact and keep v4 where artifacts are used? That would avoid the interaction issue |
|
no, a half job is worse than a full job. v5 doesn't buy us enough to be urgent and we should get to the bottom of why this isn't happy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 24 compatibility: switch all jobs to actions/checkout@v5. Requires runner v2.327.1+. Pure maintenance, behavior unchanged.
Ref: https://github.com/actions/checkout/releases/tag/v5.0.0