-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Feature: Add default name and auto-select text when creating new folder #17942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feature: Add default name and auto-select text when creating new folder #17942
Conversation
|
@marlenhalvorsen it looks like this is missing the |
|
Subtitle added. “Enter an item name” now appears correctly in the create-item dialog. |
|
Thanks! Should we apply this change for other file formats as well? |
|
Thanks for the suggestion! I've looked into the handling of Because of this, only the folder case can receive a unique default label at the moment. Differentiating per file type (e.g. "New .pptx", "New .xlsx") would require passing additional ShellNewEntry/extension information into the dialog. |
|
Thanks for checking. We can merge as is and can reconsider if we receive more feedback regarding other file formats. |
yaira2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Alternatively, we can use "New document" for other file formats. |
Issue:
Closes #17845
Changes:
Test steps: