Skip to content

Fix for moe on sm110 #2190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aleozlx merged 3 commits into from
Dec 12, 2025
Merged

Fix for moe on sm110 #2190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d027074
Fix for moe on sm110
jhalabi-nv Dec 9, 2025
80429f7
Revert changes in dispatch function
jhalabi-nv Dec 10, 2025
fa5886d
Clang-format edits
jhalabi-nv Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions csrc/nv_internal/tensorrt_llm/kernels/cutlass_kernels/cutlass_heuristic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,7 @@ std::vector<CutlassGemmConfig> get_candidate_configs_sm110(
#ifdef FAST_BUILD
// Fast build disables all configs except this
return {CutlassGemmConfig{CutlassTileConfigSM100::CtaShape128x128x128B,
MainloopScheduleType::AUTO, EpilogueScheduleType::AUTO,
MainloopScheduleType::AUTO, EpilogueScheduleType::TMA,
ClusterShape::ClusterShape_1x1x1}};
#else
std::vector<CutlassGemmConfig> candidate_configs;
Expand Down Expand Up @@ -574,7 +574,7 @@ std::vector<CutlassGemmConfig> get_candidate_configs_sm110(
std::array{ClusterShape::ClusterShape_2x1x1, ClusterShape::ClusterShape_2x2x1}};
auto cluster = cluster_shapes[cluster_m - 1][cluster_n - 1];
for (auto tile : base) {
CutlassGemmConfig config{tile, MainloopScheduleType::AUTO, EpilogueScheduleType::AUTO,
CutlassGemmConfig config{tile, MainloopScheduleType::AUTO, EpilogueScheduleType::TMA,
cluster};
candidate_configs.push_back(config);
}
Expand Down
4 changes: 3 additions & 1 deletion csrc/nv_internal/tensorrt_llm/kernels/cutlass_kernels/moe_gemm/moe_gemm_template_dispatch.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,9 @@ void MoeGemmRunner<T, WeightType, OutputType, ScaleBiasType>::dispatchToArch(
// cases with small numbers of tokens SM80 is faster. We check here to see which is selected
if (inputs.gemm_config.sm_version >= 90) {
// Check the major version of the SM matches
TLLM_CHECK_WITH_INFO(inputs.gemm_config.sm_version / 10 == sm_ / 10,
TLLM_CHECK_WITH_INFO((inputs.gemm_config.sm_version / 10 == sm_ / 10) ||
// allow sm100 configs to run on sm110 as well
(inputs.gemm_config.sm_version / 10 == 10 && sm_ / 10 == 11),
"Using SM %d configuration for SM %d device",
inputs.gemm_config.sm_version, sm_);
TLLM_CHECK_WITH_INFO(inputs.biases != nullptr || hopper_inputs.ptr_c == nullptr,
Expand Down