Add nonstring attribute to fix Clang build errors #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These character arrays are intentionally sized to exactly fit their contents without a null terminator - they are used as lookup tables, not C strings. Modern Clang fails to build with -Werror due to -Wunterminated-string-initialization. The nonstring attribute documents the intent and silences the error without requiring global compiler flag changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
__attribute__((nonstring))to two character arrays that are intentionally sized without room for a null terminator-Werroris enabledDetails
The
ais_charset(64-char AIS lookup table) andspinner(4-char animation) arrays are used as raw byte lookup tables, not C strings. Clang's-Wunterminated-string-initializationwarning (promoted to error by-Werror) causes the build to fail.The
nonstringattribute is the idiomatic fix—it documents intent and is more targeted than disabling the warning globally via compiler flags.Test plan