Fix floating point platform discrepancies; replace deprecated call to Py_SetProgramName; Remove ref to internal python type #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make Tohil_TD_iter_repr receive be proper argument, the actual iterator type that goes with it, Tohil_TD_IterObj. * Conform Tohil_TD_iter_repr to reference its object using the standard "self" name.
* In Tohil_Init, use Python's PyConfig means of configuring the Python interpreter in place of the deprecated Py_SetProgramName. * Also when Tcl is the parent, use the PyConfig method of telling Python not to install signal handlers. This should work with Python versions back to and including 3.8.
Conform Tohil's behavior of tclobj python object's floor division and remainder implementations both inplace and in-calculation, to Python's way of doing it as seen in cpython/Objects/floatobject.c.
Member
|
Probably need to modify https://github.com/flightaware/tohil/blob/main/.github/workflows/linux-ci.yml#L31 with the change in 636014c ? |
Member
|
I updated the version of python to 3.12 to work with the Ubuntu 24.04.2 runner Github is using, but one check is still failing: Test file error: :1: DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC). Investigating updating the tests to ignore this since it's a warning. |
Use of datetime.datetime.utcfromtimestamp() triggers a deprecation warning under Python 3.13. This commit changes the call to use datetime.datetime.fromtimestamp() instead, in accordance with the recommendation of the deprecation warning message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve discrepancies in certain floating point calculations between x86 and ARM
Use PyConfig in place of deprecated Py_SetProgramName
This should be compatible with Python versions back to and including 3.8.
Remove ref to internal python type in Tohil_TD_iter_repr