Improvements with the Request class #659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements micro optimizations for the Request class, which is heavily used on every request. The changes focus on improving performance through more efficient data access patterns and reduced function calls.
- Replaces static method calls with instance methods to reduce overhead
- Optimizes URL parsing logic by avoiding unnecessary
parse_url()calls - Consolidates repeated
$_SERVERaccess through centralizedgetVar()method
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| flight/net/Request.php | Core optimizations including instance method usage, improved URL parsing, and consolidated server variable access |
| flight/net/Response.php | Uses centralized getVar() method for accessing server protocol |
| flight/Engine.php | Replaces direct $_SERVER access with Request object method for last modified header |
| tests/RequestTest.php | Adds test coverage for URL encoding, base path handling, and empty query string parsing |
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some micro optimizations for a class that's used a ton on every request.