Skip to content

Conversation

@albinahlback
Copy link
Collaborator

@albinahlback albinahlback commented Nov 4, 2025

Should solve #2458 and #2468 (comment).

Printing memory usage on other platforms than macOS and Linux is unchecked.

@fredrik-johansson
Copy link
Collaborator

fredrik-johansson commented Nov 4, 2025

The added semicolons on TIMEIT and removal of SHOW_MEMORY_USAGE seem like gratuitous API breakage.

@albinahlback
Copy link
Collaborator Author

The added semicolons on TIMEIT and removal of SHOW_MEMORY_USAGE seem like gratuitous API breakage.

And I like it! It was very annoying before when automatic indentation broke because of the lack of semicolons.

@albinahlback
Copy link
Collaborator Author

I updated the documentation as well. @fredrik-johansson what is your opinion on this? I think this is final.

@fredrik-johansson
Copy link
Collaborator

It was very annoying before when automatic indentation broke because of the lack of semicolons.

Fair enough rationale.

@albinahlback albinahlback merged commit 9f99924 into flintlib:main Nov 4, 2025
10 of 11 checks passed
@albinahlback albinahlback deleted the make_profile branch November 4, 2025 15:08
@vneiger
Copy link
Collaborator

vneiger commented Nov 4, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants