Skip to content
This repository was archived by the owner on Feb 8, 2022. It is now read-only.

Conversation

@chinalwb
Copy link

@chinalwb chinalwb commented Jan 5, 2021

What does this PR do?

This PR fixed the issue mentioned in #166 , we should never show Feb. 31 or Apr. 31.

How to test manually?

  • To reproduce:

    1. Build the app with the code base
    2. Run the sample app, taps on the first option: Click me to open single dialog
    3. Scroll to select Jan. 31
    4. Change the month picker to Feb.
    5. Check the app
  • To verify:

    1. Build the app with the branch chinalwb/SingleDateAndTimePicker
    2. Do the same actions try to reproduce the issue
    3. Check the app

Expected Behavior

  1. The app should not show Feb. 31, that makes no sense
  2. The app should show Feb. 28 or 29 (depends on the leap years)

@chinalwb
Copy link
Author

chinalwb commented Jan 5, 2021

Hi @florent37 , thanks for the great work!

Please take a look about this PR when you have some time, I hope it helps but not introduces new issues.

I am about to work out another PR for including this feature: #161 (comment), please let me know what do you think about it.

Have a nice day guy! And Happy New Year, get a much better 2021!

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant