build: remove buster, replace with bullseye when necessary #10908

aminvakil · 2025-09-19T14:03:48Z

It's been three years since buster does not gets updated from Debian Security Team and it's been a year since Debian LTS Team does not support that either.

Now that trixie has been added as well to this repository, I've removed all buster tests.

There were also some tests which only were tested on buster, I've changed them to bullseye for now to expect minimum changes, and I'm going to change them to trixie with is Debian stable now.

Enter `` in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

[N/A] Example configuration file for the change
[N/A] Debug log output from testing the change
[N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

Run local packaging test showing all targets (including any new ones) build.
Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

Documentation required for this feature

fluent/fluent-bit-docs#2068

Backporting

[N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Summary by CodeRabbit

Chores
- Switched build pipelines from Debian Buster to Debian Bullseye across releases.
- Removed Debian Buster build targets and repository entries.
Documentation
- Updated packaging documentation and comments to reflect removal of Debian Buster (and Raspbian Buster) targets.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

patrick-stephens

I would disable the build but not remove the option for folks to build, I know it's eol but that's not the same as no one uses it (look at Centos). We can just remove it from all the CI but leave the container definition I think.

aminvakil · 2025-09-19T14:36:32Z

I would disable the build but not remove the option for folks to build, I know it's eol but that's not the same as no one uses it (look at Centos). We can just remove it from all the CI but leave the container definition I think.

65c15b4

Does this suffice?

patrick-stephens · 2025-09-20T19:06:30Z

.github/actions/generate-package-build-matrix/action.yaml

          echo '{ "distro" : ['
          echo '"amazonlinux/2", "amazonlinux/2.arm64v8",'
          echo '"centos/7", "centos/7.arm64v8", "centos/8", "centos/8.arm64v8",'
-          echo '"debian/buster", "debian/buster.arm64v8", "debian/bullseye", "debian/bullseye.arm64v8",'


No need to change this, it's only for 1.9 and earlier builds

patrick-stephens · 2025-09-20T19:08:20Z

packaging/distros/raspbian/Dockerfile

 # Use buildkit to skip unused base images: DOCKER_BUILDKIT=1

-FROM balenalib/rpi-raspbian:buster AS raspbian-buster-base
+FROM balenalib/rpi-raspbian:bullseye AS raspbian-bullseye-base


This is actually changing the Raspbian build, I'm not sure we want that as it's not Debian per-se. Not sure why we jumped from buster to bookworm for Raspbian but that's not part of this change.

Please make sure you're not just globally changing any reference to the string.

patrick-stephens · 2025-09-20T19:09:16Z

packaging/testing/smoke/packages/Dockerfile.debian10

@@ -1,11 +1,11 @@
 # For staging upgrade we use the 'official-install' as the base
-ARG STAGING_BASE=docker.io/dokken/debian-10
+ARG STAGING_BASE=docker.io/dokken/debian-11


Again, this is a change that is confusing as the file we are in here is called .debian10, I think it's been a global search-and-replace when instead we should also rename the file to be clear and accurate.

Sorry, this was a mistake and I have reverted this.

Yes. It was a global search-and-replace. I wasn't sure if this file is still needed, so I have not removed it and just reverted my wrong change.

aminvakil · 2025-09-26T11:26:56Z

None of failing tests are related to this PR.

coderabbitai · 2025-09-26T11:27:28Z

Walkthrough

Updated CI workflows to use Debian Bullseye instead of Buster and removed Buster targets/entries from packaging configuration and documentation across packaging files.

Changes

Cohort / File(s)	Summary
CI workflow container upgrades `lib/cfl/.github/workflows/build.yaml`, `lib/cmetrics/.github/workflows/build.yaml`, `lib/cprofiles/.github/workflows/build.yaml`, `lib/ctraces/.github/workflows/build.yaml`	Changed Debian build job name and container image from `debian:buster` to `debian:bullseye`. No other workflow steps or control flow were modified.
Packaging target configuration `packaging/build-config.json`, `packaging/update-repos.sh`	Removed `debian/buster` and `debian/buster.arm64v8` entries from build targets and DEB_REPO_PATHS.
Documentation and comments `packaging/README.md`, `packaging/update-apt-repo.sh`	Removed Debian Buster rows from distro table and removed `debian/buster` / `raspbian/buster` from commented repo target list.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Files are few and changes are homogeneous (container image/name updates and removals). Pay quick attention to workflow names and any remaining references to buster in packaging scripts or docs.

Possibly related PRs

packaging: add debian trixie support #10728 — similar updates to packaging repository lists and packaging metadata affecting DEB targets and README entries.

Suggested reviewers

cosmo0920
niedbalski
celalettin1286

Poem

"🐰 Buster hopped off, quiet and mellow,
Bullseye arrived, smart and yellow,
Workflows bounce, packaging trimmed,
CI carrots snugly primmed. 🥕"

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title 'build: remove buster, replace with bullseye when necessary' accurately summarizes the main changes: removing Debian Buster configuration and replacing it with Bullseye in affected workflow files and build configurations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8513540 and 4b93f59.

📒 Files selected for processing (8)

lib/cfl/.github/workflows/build.yaml (1 hunks)
lib/cmetrics/.github/workflows/build.yaml (1 hunks)
lib/cprofiles/.github/workflows/build.yaml (1 hunks)
lib/ctraces/.github/workflows/build.yaml (1 hunks)
packaging/README.md (0 hunks)
packaging/build-config.json (0 hunks)
packaging/update-apt-repo.sh (1 hunks)
packaging/update-repos.sh (0 hunks)

💤 Files with no reviewable changes (3)

packaging/build-config.json
packaging/update-repos.sh
packaging/README.md

🚧 Files skipped from review as they are similar to previous changes (1)

lib/cprofiles/.github/workflows/build.yaml

🔇 Additional comments (4)

lib/cfl/.github/workflows/build.yaml (1)

103-103: Consistent Bullseye upgrade across library workflows.

The changes mirror those in lib/ctraces/.github/workflows/build.yaml, maintaining consistency across related library build configurations. All build dependencies are compatible with Bullseye.

Also applies to: 105-105

lib/cmetrics/.github/workflows/build.yaml (1)

87-87: Consistent pattern maintained across library workflows.

The third library workflow is updated with the same Buster→Bullseye transition, maintaining uniformity across lib/ctraces, lib/cfl, and lib/cmetrics.

Also applies to: 89-89

packaging/update-apt-repo.sh (1)

13-13: Comment documentation correctly reflects Buster removal.

The comment updating the list of available deployment targets accurately removes debian/buster and raspbian/buster entries while preserving the newer Debian versions including Trixie, aligning with the PR's deprecation strategy.

lib/ctraces/.github/workflows/build.yaml (1)

82-84: debian:bullseye is maintained and the image update is valid.

Debian Bullseye moved to Long-Term Support on August 15, 2024, with security updates through August 31, 2026. The official Debian Docker images for bullseye are still published and rebuilt as needed. The code change from Buster to Bullseye is correct.

For context, Bookworm is now the current stable release, and for new images the current stable is recommended unless you have specific ABI/package requirements for Bullseye and accept the August 2026 end-of-life date. Consider whether your use case warrants updating to Bookworm for longer support coverage.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

Provide your own instructions using the high_level_summary_instructions setting.
Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

📝 Description — Summarize the main change in 50–60 words, explaining what was done.

📓 References — List relevant issues, discussions, documentation, or related PRs.

📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.

📊 Contributor Summary — Include a Markdown table showing contributions:
| Contributor | Lines Added | Lines Removed | Files Changed |

✔️ Additional Notes — Add any extra reviewer context.
Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

eschabell · 2025-10-21T12:07:24Z

@patrick-stephens can you approve this to get it merged?

Docs PR fluent/fluent-bit-docs#2068 ready to go.

patrick-stephens · 2025-10-21T19:30:45Z

src/wamrc/CMakeLists.txt

      DESTINATION "${FLB_INSTALL_BINDIR}")
  endif()
-endif ()
+endif ()


You should not be changing this, it's a vendored dependency so unrelated to this change.

I'm pretty sure this is vim vs vscode default behvaiour with newline, I didn't intend to change this :)

I'll revert this.

patrick-stephens · 2025-11-05T13:26:03Z

@aminvakil can you update your commits to match the required contribution style (or squash them)

Signed-off-by: Amin Vakil <[email protected]>

cosmo0920

We'll modify cfl, cmetrics, cprofiles, and ctraces in each of repositories.
So, in this PR, we shouldn't modify them directly.

cosmo0920 · 2025-11-21T06:19:28Z

lib/cfl/.github/workflows/build.yaml

-    name: Debian Buster build to confirm no issues once used downstream
+    name: Debian Bullseye build to confirm no issues once used downstream
    runs-on: ubuntu-latest
-    container: debian:buster
+    container: debian:bullseye


You shouldn't modify under lib sources. This should be modified in each of upstream repos.

cosmo0920 · 2025-11-21T06:19:35Z

lib/cmetrics/.github/workflows/build.yaml

-    name: Debian Buster build to confirm no issues once used downstream
+    name: Debian Bullseye build to confirm no issues once used downstream
    runs-on: ubuntu-latest
-    container: debian:buster
+    container: debian:bullseye


cosmo0920 · 2025-11-21T06:19:43Z

lib/cprofiles/.github/workflows/build.yaml

-    name: Debian Buster build to confirm no issues once used downstream
+    name: Debian Bullseye build to confirm no issues once used downstream
    runs-on: ubuntu-latest
-    container: debian:buster
+    container: debian:bullseye


cosmo0920 · 2025-11-21T06:19:49Z

lib/ctraces/.github/workflows/build.yaml

-    name: Debian Buster build to confirm no issues once used downstream
+    name: Debian Bullseye build to confirm no issues once used downstream
    runs-on: ubuntu-latest
-    container: debian:buster
+    container: debian:bullseye


aminvakil requested review from celalettin1286, edsiper, fujimotos, koleini, niedbalski and patrick-stephens as code owners September 19, 2025 14:03

github-actions bot added the docs-required label Sep 19, 2025

aminvakil mentioned this pull request Sep 19, 2025

packaging: remove buster fluent/fluent-bit-docs#2068

Open

patrick-stephens reviewed Sep 19, 2025

View reviewed changes

patrick-stephens reviewed Sep 20, 2025

View reviewed changes

aminvakil force-pushed the remove_buster branch 2 times, most recently from 3a514d9 to 6304625 Compare September 20, 2025 23:14

aminvakil force-pushed the remove_buster branch from 6304625 to 586e9b3 Compare September 26, 2025 11:27

patrick-stephens reviewed Oct 21, 2025

View reviewed changes

aminvakil force-pushed the remove_buster branch 2 times, most recently from 694466f to 8513540 Compare October 22, 2025 10:53

build: remove buster, replace with bullseye when necessary

4b93f59

Signed-off-by: Amin Vakil <[email protected]>

aminvakil force-pushed the remove_buster branch from 8513540 to 4b93f59 Compare November 20, 2025 11:21

aminvakil requested a review from cosmo0920 as a code owner November 20, 2025 11:21

cosmo0920 requested changes Nov 21, 2025

View reviewed changes

build: remove buster, replace with bullseye when necessary #10908

Are you sure you want to change the base?

build: remove buster, replace with bullseye when necessary #10908

Conversation

aminvakil commented Sep 19, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

patrick-stephens left a comment

Choose a reason for hiding this comment

Uh oh!

aminvakil commented Sep 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aminvakil commented Sep 26, 2025

Uh oh!

coderabbitai bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

eschabell commented Oct 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

patrick-stephens commented Nov 5, 2025

Uh oh!

cosmo0920 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aminvakil commented Sep 19, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 26, 2025 •

edited

Loading