Add a flag to ignore the trailing line break in text height calculations#1626
Open
hollandjake wants to merge 5 commits intofoliojs:masterfrom
Open
Add a flag to ignore the trailing line break in text height calculations#1626hollandjake wants to merge 5 commits intofoliojs:masterfrom
hollandjake wants to merge 5 commits intofoliojs:masterfrom
Conversation
…ons (including tables)
Contributor
Author
|
error failure looks to be another issue of OS based discrepancies |
hollandjake
force-pushed
the
text-last-line-gap
branch
from
9951561 to
6f0ad21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Introduces a new flag to the text height calculations (and renderer) such that when disabled (enabled by default to maintain backwards compatibility) the trailing line break is not rendered.
This fixes a bug discovered in #1620
Checklist:
This is also inherently supported by the tabular system under
{textOptions: {trailingLineBreak: false}}