fix(picker.actions): put action always moving cursor to the EoL
#2520
+12
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when used in insert mode, the
putaction, by default used by theiconsource, always moves the cursor to the end of the line instead of the end of the pasted text.The issue arises since
:startinsert!(with bang) behaves likeA, not likea. Sincenvim_pastemoves the cursor onto the last pasted character, we needato correctly position the cursor when re-entering insert mode. However,:startinsertbehaves likeiand:startinsert!likeA, so we need to check whether we are at the end of the line to determine whether we emulateilorAfor correct cursor positioning.Whether we are at the end of the line cannot simply be determined with
nvim_win_get_cursorandnvim_get_current_line, since emojis/nerdfonts affect the string length. Instead of convoluted string width calculations, usingfn.virtcolis simpler and also does the job.