feature(elm): Style recommended rooms #206
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrapacz
changed the title
Collaborator
|
I like this approach. How about setting different color for each recommended room (or custom icon)? |
Collaborator
Author
|
I think we could stay with more or less the same colour (all of the system is green atm, so I'm not sure if changing the color in one place would work well), but add special icons for each of the recommended room type. Not sure yet what the icons would be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I was thinking about a better way to style the recommended rooms. I thought we could get three special rooms from backend like the last one you played, the one you're best at and the most crowded right now.
What do you think?
we could use this pack
Related issues
n/a
Test plan
n/a