refactor: Apply Composition Pattern to QueryResultIterator #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: One giant QueryResultIterator class (200+ lines) doing everything - handling messages, processing chunks, monitoring status, and checking completion all mixed together. After: Split into 4 focused components - QueryExecutor (handles messages), ChunkProcessor (fetches data), StatusMonitor (tracks progress), and CompletionVerifier (checks completion). Why Better: Each component has a single, clear responsibility making the code easier to understand, test, debug, and maintain. Real Impact: Instead of digging through 200+ lines to fix a bug, you now know exactly which 30-line component to look at. Result: Same functionality, but much cleaner architecture that's easier to work with!
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
============================================
- Coverage 83.11% 82.79% -0.33%
+ Complexity 1245 1239 -6
============================================
Files 103 103
Lines 3713 3777 +64
Branches 373 386 +13
============================================
+ Hits 3086 3127 +41
- Misses 463 474 +11
- Partials 164 176 +12
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: One giant QueryResultIterator class (200+ lines) doing everything - handling messages, processing chunks, monitoring status, and checking completion all mixed together.
After: Split into 4 focused components - QueryExecutor (handles messages), ChunkProcessor (fetches data), StatusMonitor (tracks progress), and CompletionVerifier (checks completion).
Why Better: Each component has a single, clear responsibility making the code easier to understand, test, debug, and maintain.
Real Impact: Instead of digging through 200+ lines to fix a bug, you now know exactly which 30-line component to look at.
Result: Same functionality, but much cleaner architecture that's easier to work with!