Fix voice input #132
Fix voice input #132
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes voice input and IME (Input Method Editor) composition handling by implementing proper text editing state management. The changes ensure that IME composition sequences are correctly tracked and cleared when switching sessions or receiving new input, preventing duplicate or stale characters from appearing.
Changes:
- Added
ImeCompositionstruct to track active composition state - Implemented composition clearing logic that sends delete commands for uncommitted text
- Updated text input and editing handlers to manage composition state
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main.zig | Implements IME composition tracking, adds helper functions for codepoint counting and composition clearing, and updates event handlers to manage composition state |
| docs/architecture.md | Documents the text input event handling behavior for SDL_EVENT_TEXT_INPUT and SDL_EVENT_TEXT_EDITING |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6e61ad616
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
No description provided.