Group 3 - refactoring library class #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| crime_audio_books: list[Book] = [] | ||
| max: Optional[Book] = None | ||
|
|
||
| # print banner |
Collaborator
There was a problem hiding this comment.
Commentary not necessary. Does not say "why"
| if b._book_type == "Audio": | ||
| if max is not None and max.duration < b.duration: | ||
| max = b | ||
| # end if |
Collaborator
There was a problem hiding this comment.
# end if useless as per python
| print("********* Longest Crime Audio Book **********") | ||
| print("*********************************************") | ||
|
|
||
| for b in self.get_books(): |
Collaborator
There was a problem hiding this comment.
Can't we access _books directly?
| max = b | ||
| # end if | ||
| # end if | ||
| else: |
Collaborator
There was a problem hiding this comment.
To be removed. Same as not having an else
| if Genre.CRIME in b.genres: | ||
| if b._book_type == "Audio": | ||
| if max is not None and max.duration < b.duration: | ||
| max = b |
Collaborator
There was a problem hiding this comment.
Is max ever changed from None
| def __init__(self, books: list[Book]): | ||
| self._books = books | ||
|
|
||
| _books: list[Book] = [] |
Collaborator
There was a problem hiding this comment.
To be placed at the top
|
|
||
| class Library(): | ||
|
|
||
| # Prints crime audio books |
Collaborator
There was a problem hiding this comment.
Comment pollution: the function's name already describes what is does
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.