Generated namespaces for Thrift#52
Open
pointlessone wants to merge 2 commits intoforward3d:masterfrom
Open
Conversation
This is a bit easier to automatically namespace
There's a number of rather generically named classes in the generated Thrift files. There's a high chance of name collision between those classes and user code. To avoid the issue those constants are namespaced during the gem packaging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a number of rather generically named classes in the generated Thrift files. There's a high chance of name collision between those classes and user code. The issue has been risen in a few issues an PRs: #20, #31, #49.
Solution is a bit non-trivial for a number of reasons. The main is that Thrift lib files are generated. The solution has to accommodate full regeneration of those files. It's unlikely that upstream would easily accept namespacing since not only Ruby files would be affected by the change. However, other languages might suffer from the same deficiency.
The proposed solution is to automatically namespace potentially colliding classes during gem packaging.
The obvious downside is that the collision issue is still present when the gem is installed from GitHub and not from the package.