-
Notifications
You must be signed in to change notification settings - Fork 121
chore: implement feature clear option #1061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enext
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @Saksham-Sirohi, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add screenshots.
@mariobehling Added that clear filter button and made sure they appear within the same line across many pages as discussed with @Gagan-Ram and you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Saksham-Sirohi I have a suggestion,
your code just triggers a full page reload with no query-parameter, which works, but it makes a new http request.
Is it possible to write a python or javascript code to clear the form?
Also, please update 'trans' to 'translate'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a clear-filters action to list/search pages so users can quickly reset applied filters, addressing request #1044.
- Adds an “eraser” button next to existing filter submit buttons to clear filters.
- Wraps filter actions in a flex container and adjusts grid widths to accommodate the new control.
- Removes visible “Filter” text labels, leaving icon-only controls.
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| app/eventyay/eventyay_common/templates/eventyay_common/sessions/sessions.html | Adds clear-filters anchor and flex group around filter actions |
| app/eventyay/eventyay_common/templates/eventyay_common/orders/orders.html | Adds clear-filters anchor and flex group around filter actions |
| app/eventyay/control/templates/pretixcontrol/vouchers/tags.html | Adds clear-filters anchor; updates button container and column widths |
| app/eventyay/control/templates/pretixcontrol/vouchers/index.html | Adds clear-filters anchor; updates button container and column widths |
| app/eventyay/control/templates/pretixcontrol/user/orders.html | Adds clear-filters anchor and flex group around filter actions |
| app/eventyay/control/templates/pretixcontrol/subevents/index.html | Adds clear-filters anchor and flex group around filter actions |
| app/eventyay/control/templates/pretixcontrol/search/orders.html | Adds clear-filters anchor; replaces text-right with grid column and flex group |
| app/eventyay/control/templates/pretixcontrol/organizers/index.html | Adds clear-filters anchor and flex group around filter actions |
| app/eventyay/control/templates/pretixcontrol/organizers/giftcards.html | Adds clear-filters anchor and flex group around filter actions |
| app/eventyay/control/templates/pretixcontrol/organizers/detail.html | Adds clear-filters anchor; replaces text-right with grid column and flex group |
| app/eventyay/control/templates/pretixcontrol/orders/refunds.html | Adds clear-filters anchor and flex group around filter actions |
| app/eventyay/control/templates/pretixcontrol/orders/overview.html | Adds clear-filters anchor; updates button container and column widths |
| app/eventyay/control/templates/pretixcontrol/orders/index.html | Adds clear-filters anchor and consolidates actions in one flex group |
| app/eventyay/control/templates/pretixcontrol/checkin/index.html | Adds clear-filters anchor and flex group around filter actions |
| app/eventyay/control/templates/pretixcontrol/admin/users/index.html | Adds clear-filters anchor and flex group around filter actions |
| app/eventyay/control/templates/pretixcontrol/admin/task_management/task_management.html | Adds clear-filters anchor; replaces text-right with grid column and flex group |
| app/eventyay/control/templates/pretixcontrol/admin/submissions/index.html | Adds clear-filters anchor and flex group around filter actions |
| app/eventyay/control/templates/pretixcontrol/admin/organizers.html | Adds clear-filters anchor and flex group around filter actions |
| app/eventyay/control/templates/pretixcontrol/admin/events/index.html | Adds clear-filters anchor; replaces text-right with grid column and flex group |
| app/eventyay/control/templates/pretixcontrol/admin/attendees/index.html | Adds clear-filters anchor and flex group around filter actions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
app/eventyay/eventyay_common/templates/eventyay_common/sessions/sessions.html
Outdated
Show resolved
Hide resolved
app/eventyay/eventyay_common/templates/eventyay_common/sessions/sessions.html
Outdated
Show resolved
Hide resolved
|
@Gagan-Ram implemented suggestions |
|
@Saksham-Sirohi The current code works, but my suggestion is, to clear the form either using python code or using js code and to not make extra http call again. |
54e401f to
8e4eac3
Compare
2025-10-19.13-19-49.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please avoid a full reload / an extra http call.



Request solution from #1044