Add capability for gradual rollout of transition mode #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippta
force-pushed
the
feature/granular-rollout
branch
from
fce1213 to
9dee912
Compare
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Author
|
@cursor review |
philippta
force-pushed
the
feature/granular-rollout
branch
from
851944a to
e600a41
Compare
Author
|
@cursor review |
Author
|
@cursor review |
Log domain, storage_mode, and rollout_bucket at each storage mode decision point to help observe the gradual rollout behavior.
Author
|
@cursor review |
ErikBooijFR
approved these changes
Jan 8, 2026
Replace brute-force test approach with targeted test cases that verify behavior at rollout boundaries (0%, 1%, 50%, 99%, 100%). Remove helper functions and large domain list that were only used for test generation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a way to gradually roll out the new certificate storage format. Instead of switching every domain to the new system at once, we can now move them over in small groups to ensure everything is working correctly.
Percentage-Based Rollout
CERTMAGIC_STORAGE_MODE_ROLLOUT_PERCENTallows us to control the amount of domains which enter "transition" mode.10, only 10% of all domains fall into the "rollout buckets" and enter transition mode.Why this is helpful
Notes
Proof of work
ROLLOUT_PERCENT = 40
ROLLOUT_PERCENT = 0
ROLLOUT_PERCENT = 100