Add GUI #256
Draft
Add GUI #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: gui project
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Send password | ||
| using var rsa = new RSACryptoServiceProvider(); | ||
| rsa.FromXmlString(rsaPublicKey.Key); | ||
| await _sender!.SendPacketAsync(ConnectionVerifyPackets.Password, new PasswordPacket { PasswordData = rsa.Encrypt(_hashedPassword, false) }, false, token); |
Check failure
Code scanning / CodeQL
Weak encryption: inadequate RSA padding High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 9 months ago
To fix the problem, we need to replace the insecure PKCS#1 v1.5 padding with the more secure PKCS#1 v2 (OAEP) padding. This involves changing the rsa.Encrypt method call to use OAEP padding.
- Update the
rsa.Encryptmethod call to use OAEP padding by passingtrueinstead offalse. - Ensure that the decryption process also uses OAEP padding by updating the
rsa.Decryptmethod call accordingly.
Suggested changeset
1
Lip.Connection/Connection.cs
| @@ -195,3 +195,3 @@ | ||
| rsa.FromXmlString(rsaPublicKey.Key); | ||
| await _sender!.SendPacketAsync(ConnectionVerifyPackets.Password, new PasswordPacket { PasswordData = rsa.Encrypt(_hashedPassword, false) }, false, token); | ||
| await _sender!.SendPacketAsync(ConnectionVerifyPackets.Password, new PasswordPacket { PasswordData = rsa.Encrypt(_hashedPassword, RSAEncryptionPadding.OaepSHA1) }, false, token); | ||
|
|
||
| @@ -212,3 +212,3 @@ | ||
| //if (type is not ConnectionVerifyPackets.AesKey) throw new InvalidOperationException("Failed to recive aes key."); | ||
| byte[] key = _cryptoServiceProvider.Decrypt(aesKeyPacket.Key, false); | ||
| byte[] key = _cryptoServiceProvider.Decrypt(aesKeyPacket.Key, RSAEncryptionPadding.OaepSHA1); | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
| using var rsa = new RSACryptoServiceProvider(); | ||
| rsa.FromXmlString(rsaPublicKey.Key); | ||
| byte[] key = Guid.NewGuid().ToByteArray(); | ||
| await _sender.SendPacketAsync(ConnectionVerifyPackets.AesKey, new AESKeyPacket { Key = rsa.Encrypt(key, false) }, false, token); |
Check failure
Code scanning / CodeQL
Weak encryption: inadequate RSA padding High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 9 months ago
To fix the problem, we need to change the padding scheme used in the RSA encryption from PKCS#1 v1.5 to PKCS#1 v2 (OAEP). This involves modifying the rsa.Encrypt method call to use OAEP padding.
- Update the
rsa.Encryptmethod call to use OAEP padding by passingtrueinstead offalse. - Ensure that the rest of the code remains unchanged to maintain existing functionality.
Suggested changeset
1
Lip.Connection/Connection.cs
| @@ -252,3 +252,3 @@ | ||
| byte[] key = Guid.NewGuid().ToByteArray(); | ||
| await _sender.SendPacketAsync(ConnectionVerifyPackets.AesKey, new AESKeyPacket { Key = rsa.Encrypt(key, false) }, false, token); | ||
| await _sender.SendPacketAsync(ConnectionVerifyPackets.AesKey, new AESKeyPacket { Key = rsa.Encrypt(key, RSAEncryptionPadding.OaepSHA1) }, false, token); | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Which issues does this PR resolve?
Checklist before merging
Thank you for your contribution to the repository.
Before submitting this PR, please make sure: