Skip to content
This repository was archived by the owner on Dec 11, 2020. It is now read-only.

Conversation

@gsouf
Copy link

@gsouf gsouf commented Jun 18, 2020

Hi,

This PR adds a protected method Generator::findFormatter that can get a formatter without use of cache.

The reason I propose it is that we need to define custom way to find a formatter by overiding Generator::getFormater but we cannot do it efficiently as the method makes use of cache internally. We would like to be able to keep the native cache feature of the method and just overide the way the formatter callable is found.

In other words with this change then we will be able to overide the method findFormatter without messing with the cache implementation

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants