Skip to content

Conversation

@vschnei
Copy link
Collaborator

@vschnei vschnei commented Oct 21, 2025

This merge request replaces/updates the deprecated and unstable char0n/swagger-editor-validate GitHub Action

@vschnei vschnei requested review from patmagee and vsmalladi October 21, 2025 07:32
@vschnei
Copy link
Collaborator Author

vschnei commented Oct 21, 2025

@patmagee @vsmalladi
I did not work much CI/CD with github yet.

Do have any experience with this problem? It becomes visible during PR.

@vschnei vschnei changed the title Replace Puppeteer-based Swagger validation with Node-based swagger-cli Update CI Oct 21, 2025
@vschnei vschnei force-pushed the fix_sandbox_error branch 2 times, most recently from e455c7b to e17b8e7 Compare October 21, 2025 09:24
@vschnei
Copy link
Collaborator Author

vschnei commented Oct 21, 2025

I was able to update the CI.

The CI/CD workflow for linting and validating OpenAPI specifications was failing during pull request validation.
Specifically, the validation step using swagger-editor-validate encountered a Puppeteer-related error.

The solution covered:

  1. Change "pull_request_target" to "pull_request" as the "develop" branch has the "broken" ci.yml which was used for the CI.
    2)The swagger-editor-validate action was adjusted.

@vsmalladi
Copy link
Contributor

I was able to update the CI.

The CI/CD workflow for linting and validating OpenAPI specifications was failing during pull request validation. Specifically, the validation step using swagger-editor-validate encountered a Puppeteer-related error.

The solution covered:

  1. Change "pull_request_target" to "pull_request" as the "develop" branch has the "broken" ci.yml which was used for the CI.
    2)The swagger-editor-validate action was adjusted.

Ah I would put back in the "pull_request_target" and force the merge. That way develop will work going forward.

Copy link
Contributor

@vsmalladi vsmalladi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vschnei once you make that change I think we can just force the merge for develop and this will work going forward.

on:
- push
- pull_request_target
- pull_request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would revert this back to pull_request_target that way going forward this will work. We can force this to merge now

@vschnei
Copy link
Collaborator Author

vschnei commented Oct 22, 2025

@vsmalladi changes were reverted

@vschnei vschnei requested a review from vsmalladi October 22, 2025 12:05
@vschnei vschnei merged commit 31dc086 into develop Oct 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants