fix: use powershell if available on windows #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
omg, is this project dead or what. |
|
@gajus Are you planning to review this soon? |
|
Actually it would be great to improve a package which already got 907 stars and to make it running on Windows. I have to still use a fork in a professional project... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this modifcation,
createSpwanwill attempt to usepowershell.exeon windows systems.I tested this with powershell and git bash for windows, and both did work on my machine. I am open to any feedback on my approach as I am not sure it is ideal.
I hope you will still consider adding this as i would love to be able to use turbowatch on windows.
related issue: #40