A mapping of *_PE in Parser.i6t to parser errors in the Standard Rules
#180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just created improvement request I7-2613 for this PR to refer to.
This adds comments to Parser.i6t identifying the command parser error / parser error internal rule responses to which the
*_PEconstants correspond, e.g.,and, in the Standard Rules, cross-references between command parser errors and parser error internal rule responses:
As shown, it labels the errors / messages that are now vestigial; it further comments out testing for these vestigial errors in Parser.i6t, e.g.,
These are the only changes in the PR outside of code comments.
Arguably, it'd be an improvement to elide the vestiges altogether. That would result in different numeric values for most of the
*_PEconstants and skipping letters in the rule responses (or re-lettering them, I would guess that skipping would be preferable). I erred on the side of conservatism here and just labeled them.