-
Notifications
You must be signed in to change notification settings - Fork 4
Add tags docs #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tags docs #107
Conversation
✅ Successfully deployed static |
c353ae4 to
9aee64a
Compare
9aee64a to
09e5757
Compare
docs/command-line/index.mdx
Outdated
| -s, --set <set> run tests only in the specified set | ||
| -r, --require <module> require module | ||
| --grep <grep> run only tests matching the pattern | ||
| --tag <tag> run only tests matching the pattern |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
matching the pattern
Maybe "with specified tags"?
docs/command-line/index.mdx
Outdated
| You can assign tags to a test using the `{tag: string | string[]}` parameter. | ||
| You can also add tags dynamically during test execution with the [addTag][add-tag] command, | ||
| but tests tagged this way cannot be filtered at launch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its unclear, what they cannot be filtered by
Lets write explicitly:
but you cannot use dynamic tags to filter tests at launch
| You can also add tags dynamically during test execution with the [addTag][add-tag] command, | ||
| but tests tagged this way cannot be filtered at launch. | ||
| ```ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing example of setting multiple tags in one suite/test
There should be example where tag is array
docs/commands/browser/addTag.mdx
Outdated
| await browser.addTag(["first", "second"]); | ||
| ``` | ||
|
|
||
| Also, the tag object now has the following methods: to add a tag, get a list of tags, and check if a tag exists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
following methods: to add a tag
: should be removed
now has methods to add a tag...
docs/commands/browser/addTag.mdx
Outdated
| await browser.addTag(["first", "second"]); | ||
| ``` | ||
|
|
||
| Also, the tag object now has the following methods: to add a tag, get a list of tags, and check if a tag exists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tag object
What is the tag object?
| #### Tag {#testplane-tag} | ||
| Запуск только тестов соответствующих паттерну: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
запятой не хватает
docs/command-line/index.mdx
Outdated
| ##### Example {#testplane-tag-example} | ||
| You can assign tags to a test using the `{tag: string | string[]}` parameter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super unclear, what kind of parameter is it
Maybe we should write it like this:
You can assign tags to a test like this:
<example>
| ##### Example {#testplane-tag-example} | ||
| Вы можете назначить теги тесту с помощью параметра `{tag: string | string[]}`. | ||
| Также вы можете добавлять теги динамически во время выполнения теста с помощью команды [assertTag][add-tag], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assertTag
Опечатка?
| await browser.addTag(["first", "second"]); | ||
| ``` | ||
|
|
||
| Также, объект тега теперь имеет следующие методы: для добавления тега, получения списка тегов и проверки существования тега. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Может, объект теста?
| <tr> | ||
| <td>tag</td> | ||
| <td>`string | string[]`</td> | ||
| <td>Обязательный параметр. Одна строка или массив строк.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Одна строка или массив строк
Зачем явно указывать, что "одна строка"?
Почему не "строка или массив строк"?
Ну и, кажется, тип и так понятен - написан строкой выше. Давай лучше "Название тега или тегов" просто в описании напишем
c2a7374 to
4054e6a
Compare
No description provided.