Skip to content

Conversation

@sonic16x
Copy link
Contributor

@sonic16x sonic16x commented Dec 1, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

✅ Successfully deployed static

@sonic16x sonic16x force-pushed the users/rocketraccoon/TESTPLANE-436.tags branch from 9aee64a to 09e5757 Compare December 1, 2025 11:55
-s, --set <set> run tests only in the specified set
-r, --require <module> require module
--grep <grep> run only tests matching the pattern
--tag <tag> run only tests matching the pattern
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matching the pattern

Maybe "with specified tags"?

You can assign tags to a test using the `{tag: string | string[]}` parameter.
You can also add tags dynamically during test execution with the [addTag][add-tag] command,
but tests tagged this way cannot be filtered at launch.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its unclear, what they cannot be filtered by

Lets write explicitly:

but you cannot use dynamic tags to filter tests at launch

You can also add tags dynamically during test execution with the [addTag][add-tag] command,
but tests tagged this way cannot be filtered at launch.
```ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing example of setting multiple tags in one suite/test
There should be example where tag is array

await browser.addTag(["first", "second"]);
```

Also, the tag object now has the following methods: to add a tag, get a list of tags, and check if a tag exists.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

following methods: to add a tag

: should be removed

now has methods to add a tag...

await browser.addTag(["first", "second"]);
```

Also, the tag object now has the following methods: to add a tag, get a list of tags, and check if a tag exists.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tag object
What is the tag object?

#### Tag {#testplane-tag}
Запуск только тестов соответствующих паттерну:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

запятой не хватает

##### Example {#testplane-tag-example}
You can assign tags to a test using the `{tag: string | string[]}` parameter.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super unclear, what kind of parameter is it
Maybe we should write it like this:

You can assign tags to a test like this:
<example>

##### Example {#testplane-tag-example}
Вы можете назначить теги тесту с помощью параметра `{tag: string | string[]}`.
Также вы можете добавлять теги динамически во время выполнения теста с помощью команды [assertTag][add-tag],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assertTag

Опечатка?

await browser.addTag(["first", "second"]);
```

Также, объект тега теперь имеет следующие методы: для добавления тега, получения списка тегов и проверки существования тега.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Может, объект теста?

<tr>
<td>tag</td>
<td>`string | string[]`</td>
<td>Обязательный параметр. Одна строка или массив строк.</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Одна строка или массив строк

Зачем явно указывать, что "одна строка"?
Почему не "строка или массив строк"?
Ну и, кажется, тип и так понятен - написан строкой выше. Давай лучше "Название тега или тегов" просто в описании напишем

@sonic16x sonic16x force-pushed the users/rocketraccoon/TESTPLANE-436.tags branch from c2a7374 to 4054e6a Compare December 3, 2025 13:55
@sonic16x sonic16x merged commit 64966a1 into master Dec 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants