Improve code readability by using concepts where appropriate

[liuzicheng1987]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @liuzicheng1987, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant refactoring effort to modernize the codebase by adopting C++20 concepts. The primary goal is to enhance code readability and maintainability by replacing verbose std::enable_if template constraints with the more concise and expressive requires clauses. Additionally, it improves the modularity of the parsing system by creating a dedicated parser for enum types, streamlining their handling and making the codebase easier to navigate and extend.

Highlights

• Modernized Template Constraints: Replaced numerous instances of std::enable_if with C++20 requires clauses across various header files (e.g., Attribute.hpp, Binary.hpp, Field.hpp, Generic.hpp, Result.hpp, TaggedUnion.hpp, Validator.hpp, Variant.hpp, Skip.hpp), significantly improving the readability and conciseness of template metaprogramming.
• Simplified Type Trait Definitions: Updated type trait checks in flexbuf/Reader.hpp and internal/has_to_class_method_v.hpp to leverage C++20 concepts, making them more expressive and easier to understand than their std::enable_if counterparts.
• Improved Modularity for Enum Parsing: Extracted all enum-related parsing logic from Parser_default.hpp into a new, dedicated file Parser_enum.hpp. This change centralizes enum serialization, deserialization, and schema generation, enhancing the overall structure and maintainability of the parsing components.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a great step towards modernizing the codebase by replacing SFINAE with C++20 concepts, which significantly improves code readability. The refactoring of enum parsing logic into its own file is also a good structural improvement. However, I've found a critical issue in include/rfl/flexbuf/Reader.hpp where the transition to concepts seems to be incomplete, leading to a compilation error and a change in behavior. Please see the detailed comment.

[ZXShady]

Why not using std::convertible_to?