-
Notifications
You must be signed in to change notification settings - Fork 86
/users/current: add session details #1602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
matthew-white
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I don't think we even document that endpoint actually. I think we could remove the endpoint entirely once we've stopped using it in Frontend. |
I think the reason we didn't document it is because it was originally introduced to support cookie auth. We made the decision not to document the details of cookie auth. |
|
@alxndrsn, do you think we could go ahead and merge this PR? I'm confident that I'll be able to use this change on the frontend, but I probably won't get to it until I've made more progress on maps. |
I'm happy to hold off merging until frontend code is ready. |
|
Sorry, I don't think I'm going to get to the frontend part of this before regression testing. Too much mapping to do! I'll plan to work on that at the start of v2025.4 so that we can get this PR merged soon. |
Part of getodk/central#1315: aiming to reduce chained requests for already-authenticated returning web users by one.
What has been done to verify that this works as intended?
A couple of new tests!
Why is this the best possible solution? Were any other approaches considered?
/sessions/restorebe documented as deprecated?How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Should make frontend a little faster for them sometimes.
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
Docs have been updated.
Before submitting this PR, please make sure you have:
make testand confirmed all checks still pass OR confirm CircleCI build passes