Skip to content

Conversation

@iamrajjoshi
Copy link
Contributor

@iamrajjoshi iamrajjoshi commented Jul 21, 2025

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other - Typing Update

Description

Related Issues

PR checklist

Before submitting this pull request, I have done the following:

Added/updated tests?

Current repository has 100% test coverage.

  • Yes
  • No, and this is why:
  • I need help with writing tests

@markstory
Copy link
Member

Looks good to me. I can get the typing errors fixed up.

@iamrajjoshi iamrajjoshi marked this pull request as ready for review July 21, 2025 16:17
@iamrajjoshi iamrajjoshi force-pushed the raj/exit-ret-type branch 2 times, most recently from a362d2c to 9a6db3d Compare July 21, 2025 17:02
@markstory markstory merged commit 1532e9e into master Aug 1, 2025
34 of 36 checks passed
@markstory markstory deleted the raj/exit-ret-type branch August 1, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading return type for RequestsMock.__exit__

3 participants