Fix recording content_type #771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intiial code skipped reorcding the content type and instead fell back to guessing. Now it only falls back to guessing if no explicit content type is provided. Closes getsentry#770
markstory
reviewed
Jul 21, 2025
Co-authored-by: Mark Story <[email protected]>
markstory
approved these changes
Aug 1, 2025
Member
markstory
left a comment
markstory
left a comment
There was a problem hiding this comment.
Looks good. I'll get the typing issues figured out before packaging the next release.
Contributor
Author
|
From the commit history it looks like you may have been able to solve that. Any news when we can expect you to cut a new release? I would be quite happy to remove the workarounds we have in our code. |
Member
|
@dwt I'll get a release made later this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intiial code skipped reorcding the content type and instead fell back to guessing. Now it only falls back to guessing if no explicit content type is provided.
What type of PR is this? (check all applicable)
Description
Related Issues
PR checklist
Before submitting this pull request, I have done the following:
toxandpre-commitchecks locallyAdded/updated tests?