Skip to content

Conversation

@dingsdax
Copy link
Contributor

@dingsdax dingsdax commented Jan 15, 2026

Added legal boilerplate to clarify contribution rights b/c CLI is FSL

Added legal boilerplate to clarify contribution rights b/c CLI is FSL
@dingsdax dingsdax requested review from a team and szokeasaurusrex as code owners January 15, 2026 15:04
@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Fixes

- add legal boilerplate to PR template ([#3089](https://github.com/getsentry/sentry-cli/pull/3089))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against 9f49806

@dingsdax dingsdax added the skip-changelog Apply this label to PRs that do not contain any user-facing changes label Jan 15, 2026
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I just wonder whether we should have some CI check to ensure that this message is intact for non-employees and reject the PR otherwise. Could be helpful on other repos as well.

This would be a separate PR though

@szokeasaurusrex szokeasaurusrex changed the title fix: add legal boilerplate to PR template meta: add legal boilerplate to PR template Jan 15, 2026
Copy link
Contributor Author

I don't think this is necessary. Upon opening a PR an external contributor reads this language, there needs to be a conscious action to remove it. I don't think we have such a check for our other FSL licensed repos either.

Copy link
Member

it is possible that they miss the template if they are opening the PR from gh CLI, which may become a more frequent use case with agentic coding workflows

Copy link
Contributor Author

still edge case territory for me. afaik GH CLI respect PR templates unless you override with "gh pr create --body", but that might be a nice addition to our Dangerfile … fine lets create a backlog issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Apply this label to PRs that do not contain any user-facing changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants