-
-
Notifications
You must be signed in to change notification settings - Fork 372
Structured Logs: Collect stdout/stderr
#6441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
❌ 5 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b045d0a | 1227.48 ms | 1252.22 ms | 24.75 ms |
| 21efa18 | 1227.73 ms | 1250.04 ms | 22.31 ms |
| 50a9ff7 | 1221.43 ms | 1238.07 ms | 16.64 ms |
| 0ee162c | 1226.90 ms | 1261.72 ms | 34.83 ms |
| c63e0fe | 1230.58 ms | 1253.94 ms | 23.35 ms |
| 41c0aa8 | 1222.75 ms | 1262.40 ms | 39.65 ms |
| 32584c4 | 1225.58 ms | 1256.02 ms | 30.44 ms |
| 3133d0e | 1237.86 ms | 1262.87 ms | 25.01 ms |
| 2de3f92 | 1207.56 ms | 1234.96 ms | 27.40 ms |
| 891fd1d | 1220.02 ms | 1227.60 ms | 7.57 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b045d0a | 23.75 KiB | 880.21 KiB | 856.46 KiB |
| 21efa18 | 23.75 KiB | 919.70 KiB | 895.95 KiB |
| 50a9ff7 | 23.75 KiB | 913.63 KiB | 889.89 KiB |
| 0ee162c | 23.75 KiB | 933.33 KiB | 909.58 KiB |
| c63e0fe | 23.74 KiB | 874.08 KiB | 850.33 KiB |
| 41c0aa8 | 23.75 KiB | 986.80 KiB | 963.05 KiB |
| 32584c4 | 23.75 KiB | 920.74 KiB | 896.99 KiB |
| 3133d0e | 23.74 KiB | 976.79 KiB | 953.04 KiB |
| 2de3f92 | 23.75 KiB | 919.69 KiB | 895.94 KiB |
| 891fd1d | 23.75 KiB | 919.92 KiB | 896.17 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I worry about having a feedback loop between loop and envelopes generating a never ending loop of mora data being generated, most of which will be garbage.
I see you removed SentrySDKLog.log call in SentryLogger, but I wonder if we should remove all or some Sentry logs from stdout. Have you checked that?
|
@itaybre Yeah, that worries me also. One "misplaced" stdout call by our SDK, and we run the risk of producing a never ending loop. Like you said, we'd need to change how the internal SDK logging to stdout works, but that would be something we'd need to discuss more. |
|
@itaybre @philipphofmann @noahsmartin Ok, so the logging we do internally is always prefixed with However, i'm still worrying that some where down the code path of using the logger -> hub -> client -> batcher -> transport, we could trigger some non-sentry API that will print to We could think about offering this as an optional integration to users, but still we'd have to be sure we have the loop issue solved IMHO. |
# Conflicts: # Sentry.xcodeproj/project.pbxproj # Sources/Sentry/SentryOptionsInternal.m
# Conflicts: # Sentry.xcodeproj/project.pbxproj # Sources/Swift/Tools/SentryLogger.swift
…r-creatable right now)
stdout/stderr per defaultstdout/stderr
|
The The data we get through listening to |

📜 Description
stdout/stderrand log with structured logs💡 Motivation and Context
Closes #6411
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.